Multiline+Dialog Effect Commands - #8757
Open
Absolutionism wants to merge 23 commits into
Open
Conversation
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
…to dev/feature
This comment has been minimized.
This comment has been minimized.
Member
|
I was thinking about having a command that opens a dialog where you can type multi line code |
Contributor
Author
|
Updated with Dialog |
Member
|
Do we actually need a tab character? can users not just use spaces? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skript's current effect command system has slowly become limited as more Section-typed syntax elements are created, causing the inability to test with effect commands as it only supports one line.
Solution
Multiline
Introduces multiline effect commands, allowing users to provide multiple lines before finalizing and parsing+executing
Adding 3 new options:
Each entry must start with the token, and to finalize is to send the token by itself
Allows:
Note: If both 'effect command token' and 'multiline effect command token' are the same, effect commands will always be treated as multiline.
Dialog
Using the API for multiline effect commands, allows a Dialog to be opened for a player utilizing the Dialog's Text Input for easily inputting multiple lines of code.
Also adds the ability to save the code when executing/closing the dialog to continue where you left off
Testing Completed
Manual testing, ensuring:
Supporting Information
N/A
Examples
Completes: none
Related: none
AI assistance: none